Skip to content

VMware 80u2 and 80u3 updates/fixes #10586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: 4.20
Choose a base branch
from
Open

VMware 80u2 and 80u3 updates/fixes #10586

wants to merge 8 commits into from
+91 −37

Conversation

sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Mar 19, 2025 •
edited
Loading

Description

This PR handles cleanup and power on issues with VMware 80u2 and 80u3, and some test fixes.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested VM/Volume operations manually, and with some smoke tests.

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti changed the base branch from main to 4.20 March 19, 2025 08:10
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@codecov Codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.

Project coverage is 16.01%. Comparing base (6850147) to head (2176c0c).

Files with missing lines Patch % Lines
...oud/hypervisor/vmware/resource/VmwareResource.java 0.00% 31 Missing ⚠️
...m/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 0.00% 22 Missing ⚠️
...cloud/storage/resource/VmwareStorageProcessor.java 0.00% 13 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10586      +/-   ##
============================================
- Coverage     16.01%   16.01%   -0.01%     
  Complexity    13112    13112              
============================================
  Files          5652     5652              
  Lines        495817   495855      +38     
  Branches      60045    60054       +9     
============================================
+ Hits          79404    79408       +4     
- Misses       407551   407585      +34     
  Partials       8862     8862
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache
weizhouapache approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12828

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud added this to the 4.20.1 milestone Mar 19, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12829

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u3

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u2

@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 19, 2025
@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u2) has been kicked to run smoke tests

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u1

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u1) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12768)
Environment: vmware-80u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 78805 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10586-t12768-vmware-80u3.zip
Smoke tests completed. 134 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_deploy_more_vms_than_limit_allows Error 223.40 test_deploy_vms_in_parallel.py
test_03_deploy_and_scale_kubernetes_cluster Failure 102.81 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Error 88.31 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 255.87 test_kubernetes_clusters.py
test_reboot_router Error 459.86 test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1521.98 test_network.py
test_02_restore_vm_with_disk_offering Error 104.27 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 60.25 test_restore_vm.py
test_01_snapshot_to_volume Error 9.37 test_snapshots.py
test_08_reboot_cpvm Failure 39.37 test_ssvm.py
test_01_volume_usage Error 95.45 test_usage.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12771)
Environment: vmware-80u1 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 76196 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10586-t12771-vmware-80u1.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_09_connectivity_between_network_and_vpc_tier Failure 34.56 test_ipv4_routing.py
test_11_isolated_network_with_dynamic_routed_mode Failure 163.88 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Failure 411.53 test_ipv4_routing.py
test_01_ping_in_vr_success Failure 60.52 test_diagnostics.py
test_04_autoscale_kubernetes_cluster Failure 158.03 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 800.65 test_kubernetes_clusters.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1524.38 test_network.py
test_02_restore_vm_with_disk_offering Error 58.20 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 114.73 test_restore_vm.py

@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12844

@blueorangutan
Copy link

[SF] Trillian test result (tid-12770)
Environment: vmware-80u2 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 80994 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10586-t12770-vmware-80u2.zip
Smoke tests completed. 134 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Failure 488.47 test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Error 488.49 test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Error 123.15 test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Error 123.16 test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Error 331.55 test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Error 331.58 test_internal_lb.py
test_09_connectivity_between_network_and_vpc_tier Error 149.42 test_ipv4_routing.py
test_08_upgrade_kubernetes_ha_cluster Failure 3692.24 test_kubernetes_clusters.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1524.99 test_network.py
test_02_restore_vm_with_disk_offering Error 60.36 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 102.21 test_restore_vm.py
test_01_volume_usage Error 88.37 test_usage.py

@Pearl1594
Copy link
Contributor

@blueorangutan test ol8 vmware-80u1

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti marked this pull request as ready for review April 10, 2025 06:42
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13005

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u3

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u3

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u2

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u2) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12948)

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u3

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12935)
Environment: vmware-80u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 84851 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10586-t12935-vmware-80u3.zip
Smoke tests completed. 133 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_03_create_vpc_domain_vpc_offering Error 26.37 test_domain_vpc_offerings.py
test_08_upgrade_kubernetes_ha_cluster Failure 32.17 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Error 24.11 test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle Error 30.34 test_kubernetes_clusters.py
ContextSuite context=TestListVolumes>:setup Error 0.00 test_list_volumes.py
test_list_system_vms_metrics_history Failure 0.32 test_metrics_api.py
ContextSuite context=TestNestedVirtualization>:setup Error 0.00 test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup Error 0.00 test_network_acl.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1521.98 test_network.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12949)
Environment: vmware-80u2 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 72429 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10586-t12949-vmware-80u2.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1523.36 test_network.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12951)
Environment: vmware-80u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 76520 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10586-t12951-vmware-80u3.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_deploy_more_vms_than_limit_allows Error 296.87 test_deploy_vms_in_parallel.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1523.92 test_network.py

@DaanHoogland
Copy link
Contributor

@sureshanaparti , good work. this test_network error seems concequent. Was that present before?

@DaanHoogland
Copy link
Contributor

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Apr 14, 2025 •
edited
Loading

@sureshanaparti , good work. this test_network error seems concequent. Was that present before?

@DaanHoogland test_network fails due to the template url "https://cloud-images.ubuntu.com/releases/22.04/release/ubuntu-22.04-server-cloudimg-amd64.ova" returns redirection response (302). I've updated the new url "https://cloud-images.ubuntu.com/releases/jammy/release/ubuntu-22.04-server-cloudimg-amd64.ova" in marvin test data in this PR, seems it's not taking from there. this is failing in other PRs as well.

@weizhouapache
Copy link
Member

@sureshanaparti , good work. this test_network error seems concequent. Was that present before?

@DaanHoogland test_network fails due to the template url "https://cloud-images.ubuntu.com/releases/22.04/release/ubuntu-22.04-server-cloudimg-amd64.ova" returns redirection response (302). I've updated the new url "https://cloud-images.ubuntu.com/releases/jammy/release/ubuntu-22.04-server-cloudimg-amd64.ova" in marvin test data in this PR, seems it's not taking from there. this is failing in other PRs as well.

@sureshanaparti
I've updated test_data.py.j2 just now. let's rekick the test

@weizhouapache
Copy link
Member

@blueorangutan test ol8 vmware-80u3

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

@sureshanaparti
Copy link
Contributor Author

@sureshanaparti , good work. this test_network error seems concequent. Was that present before?

@DaanHoogland test_network fails due to the template url "https://cloud-images.ubuntu.com/releases/22.04/release/ubuntu-22.04-server-cloudimg-amd64.ova" returns redirection response (302). I've updated the new url "https://cloud-images.ubuntu.com/releases/jammy/release/ubuntu-22.04-server-cloudimg-amd64.ova" in marvin test data in this PR, seems it's not taking from there. this is failing in other PRs as well.

@sureshanaparti I've updated test_data.py.j2 just now. let's rekick the test

thanks @weizhouapache

@blueorangutan
Copy link

[SF] Trillian test result (tid-12977)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 66920 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10586-t12977-vmware-70u3.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_04_list_domains_level_filter Failure 0.04 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_05_list_volumes_isrecursive Failure 0.06 test_list_volumes.py
test_07_list_volumes_listall Failure 0.05 test_list_volumes.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1523.16 test_network.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12983)
Environment: vmware-80u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 67851 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10586-t12983-vmware-80u3.zip
Smoke tests completed. 137 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_05_ping_in_cpvm_success Failure 15.49 test_diagnostics.py
test_04_list_domains_level_filter Failure 0.05 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_05_list_volumes_isrecursive Failure 0.06 test_list_volumes.py
test_07_list_volumes_listall Failure 0.05 test_list_volumes.py
test_01_deployVMInSharedNetwork Error 237.57 test_network.py

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u2

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u2) has been kicked to run smoke tests

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test ol8 vmware-80u3

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees
No one assigned
Labels
component:integration-test component:marvin component:vmware Python Warning... Python code Ahead!
Projects
ACS 4.20.1
Status: In Progress
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.
6 participants
@sureshanaparti @blueorangutan @weizhouapache @Pearl1594 @DaanHoogland @rohityadavcloud